Update data for the Popover API #19428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
Heh, fixed! |
Elchi3
reviewed
Apr 26, 2023
api/HTMLElement.json
Outdated
| @@ -388,7 +388,8 @@ | |||
| "spec_url": "https://html.spec.whatwg.org/multipage/indices.html#event-beforetoggle", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": "114" | |||
| "version_added": "114", | |||
| "notes": "Only available on elements that include the <code>popover</code> attribute." | |||
There was a problem hiding this comment.
Is this behavior per spec (then why do we have this note?) or is it a bug in Chrome? (should we add partial_implementation then?)
There was a problem hiding this comment.
Doh, good point. Yes, these are per spec, and not particular to Chrome. And the pages explain them. Removed.
api/HTMLElement.json
Outdated
| @@ -2092,7 +2093,8 @@ | |||
| "spec_url": "https://html.spec.whatwg.org/multipage/indices.html#event-toggle", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": "114" | |||
| "version_added": "114", | |||
| "notes": "Only available on non-<code><details></code> elements that include the <code>popover</code> attribute." | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Popover API is going to be available in Chrome 114. I've had this confirmed by the relevant engineers, and it is also reflected by the platform status entry: https://chromestatus.com/feature/5463833265045504.
Some of the compat data for this API was already added, but this PR completes it.
See my research document for further details of what has been added in this PR.
cc @keithamus