Moodle-mod_customcert_patch_rh #637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include name of student and name of the course in the PDF certificate so as to ease organization of the certificates downloaded, solving issue mdjnelson#455
Changed tabs and try to distinguish fullname and full_name. If still persists the error maybe we can´t use fullname($USER)? I have added also defined('moodle_internal') || die(); if that´s the problem.
Add student name to PDF certificate file
@mdjnelson ammendments and corrections. I have changed full_name to fullname again. I expect everything works now.
Added original space in line 266.
|
Can you squash all your commits and please look at https://github.com/mdjnelson/moodle-mod_customcert/pull/637/files to confirm all tabs are gone and you are just adding what is necessary? Thanks. |
mdjnelson
force-pushed
the
MOODLE_404_STABLE
branch
from
3cbcd9a
to
94cfd4b
Compare
Include name of student and name of the course in the PDF certificate so as to ease organization of the certificates downloaded, solving issue mdjnelson#455 Erase tabs Added new space in line 266 Added original space in line 266. Corrected mistakes from @mdjnelson comments @mdjnelson ammendments and corrections. I have changed full_name to fullname again. I expect everything works now. Add student name to PDF certificate file Add student name to PDF certificate file Update template.php Changed tabs and try to distinguish fullname and full_name. If still persists the error maybe we can´t use fullname($USER)? I have added also defined('moodle_internal') || die(); if that´s the problem.
…icardoh34/moodle-mod_customcert into moodle-mod_customcert_patch_rh
|
I think I squashed but I´m not used to github, sorry |
|
Hope it´s ok now |
mdjnelson
reviewed
Aug 31, 2024
| FROM {customcert} c, {course} cr | ||
| WHERE c.id = :templateid | ||
| AND c.course = cr.id"; | ||
| $course = $DB->get_record_sql($sql, array('templateid' => $this->id)); |
There was a problem hiding this comment.
The SQL parameters have to be aligned. See https://moodledev.io/general/development/policies/codingstyle/sql#indentation.
mdjnelson
reviewed
Aug 31, 2024
| @@ -273,7 +273,7 @@ public function delete_element($elementid) { | |||
| public function generate_pdf(bool $preview = false, ?int $userid = null, bool $return = false) { | |||
| global $CFG, $DB, $USER; | |||
|
|
|||
| if (empty($userid)) { | |||
| if (empty($userid)) { | |||
|
Can you please squash all your commits and include the issue number from https://github.com/mdjnelson/moodle-mod_customcert/issues if there is any? Your commit message could be something like - "Add user and filename to generates PDF (#123)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there are no tabs now, Still the same code for naming the user certificate