Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction of private digital signature parameters to external configuration #462

Open
wants to merge 1 commit into
base: MOODLE_38_STABLE
Choose a base branch
from

Conversation

Kencho
Copy link

@Kencho Kencho commented Sep 22, 2021

To preserve the privacy of critical parts of the digital signature (private key and password), this patch allows to configure them externally in the site configuration (i.e., config.php and the like).

Two new configuration parameters are introduced, customcert_signature_private_keys and customcert_signature_passwords. Both are associative arrays with a similar structure. Their values are the value/location of the private keys and the passwords, respectively. Their keys are the context_id of the digital signature element instances. If no such key is found, a wildcard key '*' is looked for (useful, for instance, when the whole site will share the same signing certificate configuration). If none of them is defined, falls back to the previous behaviour (i.e., configured by editing the element in the site administration interface).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant