Fix up polymorphism for core model types #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't yet tested the conversion script with these changes. I think it'll need a tweak or two. I'll try to get to that later today. |
emeryr-upenn
requested changes
Jan 28, 2025
|
Thanks for the suggestions! I've applied them all. |
Previously the manuscript, holding, and record classes weren't doing much. They were added with an eye toward polymorphism, but the ExportRepresenter was converting all item hashes unconditionally to a generic DsItem object with methods applicable to all three. This change gets ExportRepresenter working as intended so that Holding, Manuscript, and Record objects are created by ExportRepresenter where appropriate. DsItem is removed as no longer needed, and all unused methods of the core model types are removed as well. The spec helper export hash is also updated to accommodate these changes. Addresses comment on #3
Co-authored-by: emeryr-upenn <[email protected]>
mdholloway
force-pushed
the
core_model_types
branch
from
8545195 to
bd1cfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the manuscript, holding, and record classes weren't doing much. They were added with an eye toward polymorphism, but the ExportRepresenter was converting all item hashes unconditionally to a generic DsItem object with methods applicable to all three.
This change gets ExportRepresenter working as intended so that Holding, Manuscript, and Record objects are created by ExportRepresenter where appropriate. DsItem is removed as no longer needed, and all unused methods of the core model types are removed as well.
The spec helper export hash is also updated to support these changes.
Addresses comment on #3