boot: espressif: integrate Espressif Port with Zephyr sysbuild system #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Almir Okato <[email protected]>
nordicjm
reviewed
Mar 14, 2025
boot/espressif/CMakeLists.txt
Outdated
| set(APP_NAME mcuboot_${MCUBOOT_TARGET}) | ||
| set(APP_EXECUTABLE ${APP_NAME}.elf) | ||
| set(EXPECTED_IDF_HAL_VERSION "5.1.4") | ||
| find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) |
There was a problem hiding this comment.
bit confused here, if sysbuild is set then this should already be from zephyr scope, why is this finding zephyr when it is running from zephyr?
There was a problem hiding this comment.
This is needed because the project is being included as an external Zephyr project from sysbuild (zephyrproject-rtos/zephyr#87710).
MCUboot Zephyr port does the same to include the Zephyr environment.
almir-okato
force-pushed
the
mcuboot_espressif_port_with_zephyr
branch
2 times, most recently
from
5676b80 to
800faa0
Compare
2 tasks
almir-okato
force-pushed
the
mcuboot_espressif_port_with_zephyr
branch
2 times, most recently
from
a75b378 to
6f3a8d2
Compare
Enable building MCUboot Espressif Port through Zephyr's sysbuild for Espressif chips. This commit creates boot/espressif/zephyr directory and files required by Zephyr's build system to build Espressif Port through sysbuild or as "out-of-tree" project. It also moves shared parts from the main espressif/CMakeLists.txt script. Signed-off-by: Lucas Tamborrino <[email protected]> Signed-off-by: Almir Okato <[email protected]>
almir-okato
force-pushed
the
mcuboot_espressif_port_with_zephyr
branch
from
6f3a8d2 to
386a478
Compare
|
@nordicjm I've changed what you pointed, could you please take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables building MCUboot Espressif Port through Zephyr's sysbuild for Espressif chips.
Note that these changes affects only the Espressif Port build, nothing was changed on Zephyr Port of MCUboot.