Update utils.ts #27
Update utils.ts #27
Conversation
dimIndex now allows starting from zero
src/utils.ts
Outdated
| if ( start < 0 || end < 0 || end<start ) { | ||
| throw new Error('dimIndex Element Range Spec invalid.'); | ||
| } | ||
| /* if (!start || !end) { |
There was a problem hiding this comment.
Actually this is necessary undefined check
You can replace this with
if (start === undefined || end === undefined) {
return [];
}
|
fix #23 |
|
Hello again, |
|
just to avoid something like this: |
| } | ||
|
|
||
| if (start === undefined || end === undefined) { | ||
| return []; |
There was a problem hiding this comment.
still has indent issues
tabs instead spaces, 4 space indent
Please, use lint before commit
|
Works fine to me |
|
well, because kossnikita has verified it works - is it possible to merge and update ? |
|
@kossnikita well, because the pull request is still open :-( , its possible to send the working extension to me ? |
|
You have to build it by yourself. You require node.js and yarn npx vsce package --yarnIt generates |
|
ok, THX, now it works also for me ;-) |
|
Please note, you should fix issues I mentioned before. Use |
dimIndex now allows starting from zero