Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stroke width scaling in hue ring #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix stroke width scaling in hue ring #86

wants to merge 2 commits into from

Commits on Aug 4, 2022

  1. Fix hue ring rendering outside of it's bounds 

    The hue ring was rendering outside of it's bounds because drawCircle
draws the stroke width half before the radius and the other half after.

This commit fixes that by subtracting half the stroke width from the
radius.

HueRingPicker was adjusted to retain it's previous UI and to allow for
larger stroke widths without clipping
    @JCapucho
    JCapucho committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8f02ed7 View commit details
    Browse the repository at this point in the history

  2. Fix hue ring thumb not scaling with stroke width

    @JCapucho
    JCapucho committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    689eb4d View commit details
    Browse the repository at this point in the history