Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented option to remove color indicator and to change the width of the pallet type slider #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SayuruSandaru
Copy link

Now the developers can remove the color indicator by setting displayColorIndicator to false. the default value is true. And also to fill the excess space they can change the width of the PalletType slider. You can change this by setting palletTypeSliderWidth. default value is 225 which comes from default colorPickerWidth - 75.00. This option is only available when the displayColorIndicator is set to false.

Now the developer can remove the color indicator if they doesn't need to show.
Palette type slider width can be changed if the user has set the `displayColorIndicator` to false. If not default value is shown
@iqfareez
Copy link

This is nice addition; I hope the author can merge this PR.

@@ -290,18 +294,28 @@ class _ColorPickerState extends State<ColorPicker> {
mainAxisAlignment: MainAxisAlignment.center,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some padding just above this line that looks like this:
padding: const EdgeInsets.fromLTRB(15.0, 5.0, 10.0, 5.0),

When widget.displayColorIndicator is false, could you make it so the left and right padding are both 10? Else we end up with the slider being pushed slightly to the right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants