Merge pull request github#1074 from xiemaisi/js/socket.io-comm

Approved by esben-semmle
mchammer01 · Mar 13, 2019 · 6baf526 · 6baf526
2 parents 5f480af + f540dcb
commit 6baf526
Show file tree

Hide file tree

Showing 56 changed files with 846 additions and 192 deletions.
diff --git a/change-notes/1.21/analysis-javascript.md b/change-notes/1.21/analysis-javascript.md
@@ -0,0 +1,18 @@
+# Improvements to JavaScript analysis
+
+## General improvements
+
+* Support for the following frameworks and libraries has been improved:
+  - [socket.io](http://socket.io)
+
+## New queries
+
+| **Query**                                     | **Tags**                                             | **Purpose**                                                                                                                                                                 |
+|-----------------------------------------------|------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+
+## Changes to existing queries
+
+| **Query**                                  | **Expected impact**          | **Change**                                                                   |
+|--------------------------------------------|------------------------------|------------------------------------------------------------------------------|
+
+## Changes to QL libraries
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Nodes.qll b/javascript/ql/src/semmle/javascript/dataflow/Nodes.qll
@@ -325,6 +325,9 @@ class FunctionNode extends DataFlow::ValueNode, DataFlow::SourceNode {
   /** Gets the number of parameters declared on this function. */
   int getNumParameter() { result = count(astNode.getAParameter()) }
 
+  /** Gets the last parameter of this function. */
+  ParameterNode getLastParameter() { result = getParameter(getNumParameter()-1) }
+
   /** Holds if the last parameter of this function is a rest parameter. */
   predicate hasRestParameter() { astNode.hasRestParameter() }