feat: add Server-Timing headers/trailers where relevant
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 95.13% 95.20% +0.06%
==========================================
Files 10 10
Lines 1725 1750 +25
==========================================
+ Hits 1641 1666 +25
Misses 48 48
Partials 36 36
|
mccutchen
added a commit
to mccutchen/httpbingo.org
that referenced
this pull request
Sep 19, 2024
In mccutchen/go-httpbin#184 and mccutchen/go-httpbin#186, go-httpbin added HTTP trailers to some endpoints. Our current host, fly.io, does not support trailers for HTTP/1.1 requests, but does support them for HTTP/2 requests. Properly handling HTTP/2 requests requires opting in to using the h2c protocol (basically, HTTP/2 in cleartext, masquerading as HTTP/1.1). See discussion here for more context: https://community.fly.io/t/support-for-http-trailers/21915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add Server-Timing headers/trailers to endpoints that let clients control response timing:
/delay(header)/drip(header)/sse(trailer)Here's how this timing info is surfaced in the Firefox network inspector for the
/sseendpoint: