feat: add a kustomize base to the repository #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-callahan
force-pushed
the
add-kustomization
branch
from
40c08d9
to
aa55f17
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 95.11% 93.37% -1.75%
==========================================
Files 9 12 +3
Lines 2171 2280 +109
==========================================
+ Hits 2065 2129 +64
- Misses 72 105 +33
- Partials 34 46 +12 |
mccutchen
reviewed
Aug 22, 2023
|
Gonna close this for now. @james-callahan please feel free to reopen when you have the bandwidth to finish it! |
|
@mccutchen I can't reopen myself. Aside from the minor typo above, isn't this mergable event without a note in the main readme? |
|
Yes, it's mergeable as-is, but I'd prefer to merge it with a reference in the README. If you're not interested in adding that yourself, let me know and I can take care of it. Also, to get CI checks to pass, I think this will also require merging in or rebasing on main. |
james-callahan
force-pushed
the
add-kustomization
branch
from
aa55f17
to
60dfafd
Compare
|
@mccutchen I have rebased and added the requested note in the main readme. |
mccutchen
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a kustomize application that stands up a running instance of go-httpbin in a Kubernetes cluster.
This is useful to reference as a remote kustomization via your own kustomization, or can be used as:
kustomize build github.com/mccutchen/go-httpbin/kustomize | kubectl apply -f -or even as:
kubectl apply -k github.com/mccutchen/go-httpbin/kustomize