Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNION table handling #31

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Add UNION table handling #31

merged 4 commits into from
Feb 10, 2025

Conversation

Bankso
Copy link
Contributor

@Bankso Bankso commented Feb 6, 2025

  • added logic to use UNION table schema name Pubmed Id for Id column name if the PublicationView_UNION table Synapse Id is provided at the command line

- added logic to use UNION table schema name Pubmed Id if the PublicationView_UNION table Synapse Id is provided at the command line
@Bankso Bankso requested a review from vpchung February 6, 2025 22:20
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I do have one suggestion that I think we should update, as it's a bit redundant. The second comment I added is merely a suggestion :-)

pubmed_crawler.py Outdated Show resolved Hide resolved
pubmed_crawler.py Outdated Show resolved Hide resolved
Bankso and others added 2 commits February 6, 2025 15:11
Co-authored-by: Verena Chung <[email protected]>
Co-authored-by: Verena Chung <[email protected]>
@Bankso Bankso requested a review from vpchung February 8, 2025 01:24
@vpchung vpchung merged commit e38a403 into main Feb 10, 2025
@vpchung vpchung deleted the add-union-table-handling branch February 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants