-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant curation updates #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a0b0269.
This reverts commit f907fd3.
This reverts commit a00c00b.
Updates valid values + make
- Add the following new grant numbers as valid values for all 'grant number' related attributes: CA280984, CA280849, CA280829, CA284090, CA284086, CA274504, CA283114, CA274507, CA274506, CA274511 - Add the following as a valid value for the attribute Grant Institution Name: Washington University in St. Louis - Add the following as a valid value for the attribute Grant Institution Alias: WUSTL
Add the following new grant numbers as valid values for all 'grant number' related attributes: CA280984, CA280849, CA280829, CA284090, CA284086, CA274504, CA283114, CA274507, CA274506, CA274511 Add the following as a valid value for the attribute Grant Institution Name: Washington University in St. Louis Add the following as a valid value for the attribute Grant Institution Alias: WUSTL Grant Start Date - this should be REQUIRED and validated as a date, ideally in YYYY-MM-DD format (see schematic validation rule here: https://sagebionetworks.jira.com/wiki/spaces/SCHEM/pages/2645262364/Data+Model+Validation+Rules#date) . A description for this attribute can be, "The start date of the grant" NIH RePORTER Link - this should be REQUIRED and validated as a URL (see schematic validation rule here: https://sagebionetworks.jira.com/wiki/spaces/SCHEM/pages/2645262364/Data+Model+Validation+Rules#URL-Validation-Type). A description for this attribute can be, "Link to the search results for this grant number on the NIH Reporter website" Duration of Funding - this should be OPTIONAL. A description for this attribute can be, "Duration of the funding period, in years" Duration of Data Embargo - this should be OPTIONAL. A description for this attribute can be, "Duration that the data are embargoed, in months"
This was referenced Dec 1, 2023
Bankso
reviewed
Dec 1, 2023
modules/grant/annotationProperty.csv
Outdated
Grant Investigator,Investigator(s) associated witht the grant. 1...*,,,TRUE,,,,,list like | ||
Grant Consortium Name,Consortium(s) associated with the grant. 1...1,"CCBIR, CSBC, HTAN, ICBP, MetNet, NCI, NCI Clinical and Translational Exploratory/Developmental Studies, PDMC, PS-ON, Sage Bionetworks, TEC",,TRUE,,,,, | ||
GrantView_id,A unique primary key that enables record updates using schematic.,,,TRUE,,,,,unique | ||
Grant Start Date,The start date of the grant YYYY-MM-DD format,,,TRUE,,,,,date | ||
NIH RePORTER Link,Link to the search results for this grant number on the NIH Reporter website,,,TRUE,,,,,url | ||
Duration of Funding,"Duration of the funding period, in years",,,FALSE,,,,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For duration of funding and embargo, I would add "int" as the validation rule (rules are defined on this page)
Adding int as validation rule for duration of funding and embargo
…models into data-models-dev
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grant Curation Updates