Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileView, Study, and terms for light sheet microscopy dataset #123

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

Bankso
Copy link
Contributor

@Bankso Bankso commented Jul 19, 2024

Changelog

  • Added FileView and Study attributes and schema definitions
  • Added Zebrafish as species
  • Added DAE as dataset format
  • Added Multiscale Light Sheet Microscopy as an assay
  • Add Component Keys with unique validation rule

@Bankso Bankso added the minor PR label for a minor update label Jul 19, 2024
@Bankso
Copy link
Contributor Author

Bankso commented Jul 19, 2024

@aditigopalan could you take a quick look at this PR when you have a second? I've already generated a manifest based on these additions, so I think it should be good to go. I'd like to get this FileView model merged so I can add it to our data model docs

* Create file.md

* Create study.md

* Create valid values file.md

* Add file and study to hooks

* Add study and file markdown to nav

* Create FileView.csv

* Create Study.csv
Copy link
Contributor

@aditigopalan aditigopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@aditigopalan aditigopalan merged commit 48c38c0 into main Jul 22, 2024
1 check passed
@aditigopalan aditigopalan deleted the add-fileview branch July 22, 2024 13:35
@@ -0,0 +1,63 @@
List of standard terms for the [Dataset Sharing Plan Model](../model/file.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List of standard terms for the [Dataset Sharing Plan Model](../model/file.md).
List of standard terms for the [File Model](../model/file.md).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, made a suggestion without realizing the PR has already been merged.

I will file this as a bug instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor PR label for a minor update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants