Add CSS for elevator takeover #2394
Open
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
approved these changes
Jan 13, 2025
robbie-sundstrom
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad-hoc
Betsy called out two issues seen with elevator screens showing evergreen content in slack, one of them being that the screen was appearing very small.
I'm not sure if I have the explanation down quite right, but I think this was happening because we were missing the appropriate CSS classes for elevator screen takeovers and so the typical down-scaling that we do to size screens appropriately into Screenplay was being applied to the screen's dimensions and not the takeover container's dimensions.