Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Account for 3-part node descriptions #868

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

PaulJKim
Copy link
Collaborator

@PaulJKim PaulJKim commented Jan 7, 2025

Summary of changes

Asana Ticket: Process ARINC JSON for LivePA connectivity into Splunk

After deploying the initial change, we lost logging of some device types. I think this is due to the description screen for these devices only having three parts to them rather than 4. Oddly, I'm not able to find any MatchError logs in Splunk which is what I would expect, but the Endpoint process is crashing every 2 minutes which is the cadence at which we receive device status logs.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • If signs.json was changed, there is a follow-up PR to signs_ui to update its dependency on this project
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes (compare on Splunk: staging vs. prod)

@PaulJKim PaulJKim requested a review from a team as a code owner January 7, 2025 19:15
@PaulJKim PaulJKim merged commit 1bffc1d into main Jan 7, 2025
2 checks passed
@PaulJKim PaulJKim deleted the pk/bugfix-device-monitoring branch January 7, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants