Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust harvard busway config #830

Merged
merged 1 commit into from
Oct 16, 2024
Merged

adjust harvard busway config #830

merged 1 commit into from
Oct 16, 2024

Conversation

panentheos
Copy link
Collaborator

Summary of changes

Asana Ticket: Fix up Harvard busway berth assignments (again)

This modifies the sign config according to the above ticket.

@panentheos panentheos marked this pull request as ready for review October 15, 2024 15:03
@panentheos panentheos requested a review from a team as a code owner October 15, 2024 15:03
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to the assignments in the task!

{
"sources": [
{
"stop_id": "20761",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stop still seems to be present in GTFS. Should we leave it in for each of the routes, in case a trip is ever predicted to "the busway" rather than a specific berth?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Dave M, this stop should not be used for any predictions (in the current rating). It's not out of the question that it could be re-used in the future, but that would presumably require additional config changes anyway, so I think we should err on the side of not having unused stuff sitting around.

@panentheos panentheos merged commit 515328e into main Oct 16, 2024
3 checks passed
@panentheos panentheos deleted the bhw/harvard branch October 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants