Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GL routes in signs.json #714

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix GL routes in signs.json #714

merged 3 commits into from
Oct 23, 2023

Conversation

PaulJKim
Copy link
Collaborator

Summary of changes

Asana Ticket: Investigate modifying headway destination based on (GL branch) service suspensions

In #663 we removed an old piece of logic that filtered predictions based off of the routes field in the source config. Now that that's gone, we don't need to do weird stuff in the signs.json file in order to get outlier predictions to show (ex. the occasional D train going down the Medford branch).

This change adjusts the routes fields for a handful of GL stations so that they accurately reflect what branches typically serve them. The change is also meant to set us up in anticipation of future logic for checking for downstream suspensions.

@PaulJKim PaulJKim requested a review from panentheos October 20, 2023 19:17
@github-actions
Copy link

Coverage of commit b20d80e

Summary coverage rate:
  lines......: 73.9% (1943 of 2631 lines)
  functions..: 79.4% (538 of 678 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions
Copy link

Coverage of commit b20d80e

Summary coverage rate:
  lines......: 73.8% (1942 of 2631 lines)
  functions..: 79.4% (538 of 678 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions
Copy link

Coverage of commit 3cb437e

Summary coverage rate:
  lines......: 73.9% (1943 of 2631 lines)
  functions..: 79.4% (538 of 678 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@PaulJKim PaulJKim merged commit 0c6f659 into main Oct 23, 2023
@PaulJKim PaulJKim deleted the pk/sign-config-routes branch October 23, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants