Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit headways at end of service #712

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

PaulJKim
Copy link
Collaborator

@PaulJKim PaulJKim commented Oct 19, 2023

Summary of changes

Asana Ticket: Limit Headway display during end of service

Change to stop showing headway messages slightly before the last scheduled trip to be a little more accurate.

Also added a 1 min buffer to both the start of headway messages as well as the end to be slightly more accurate. For example, if the last scheduled train is at 1:00AM and the low range of headways is 5 minutes, then it would still be fair to show headways until the clock changes to 12:56AM, but 12:56AM would be [time of the last scheduled train] - 4 minutes, rather than 5 minutes.

@PaulJKim PaulJKim requested a review from panentheos October 19, 2023 16:44
@github-actions
Copy link

Coverage of commit 26acb85

Summary coverage rate:
  lines......: 74.5% (2021 of 2713 lines)
  functions..: 79.8% (557 of 698 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/engine/scheduled_headways.ex                           |97.7%     87|88.9%    18|    -      0
  lib/signs/utilities/headways.ex                            |95.2%     21| 100%     3|    -      0

Download coverage report

Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@PaulJKim PaulJKim merged commit cda2c8e into main Oct 19, 2023
1 check passed
@PaulJKim PaulJKim deleted the pk/limit-headways-end-of-service branch October 19, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants