Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update GitHub actions to use assumed role #710

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

krisrjohnson21
Copy link
Contributor

Summary of changes

Asana Ticket: Update application repos to use the new version of the GitHub action(s) (v2 tag)

This PR updates the deploy workflow to use v2 of the shared build-push-ecr and deploy-ecs actions. These updated actions assume an IAM role instead of relying on long-lasting AWS keys for an IAM user.

Note there are still workflow uses in this repo, those will be addressed as part of a follow-up subtask.

Reviewer Checklist

  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes (compare on Splunk: staging vs. prod)

@krisrjohnson21 krisrjohnson21 requested review from PaulJKim, a team and ianwestcott October 18, 2023 20:25
@github-actions
Copy link

Coverage of commit b3ca1b3

Summary coverage rate:
  lines......: 74.3% (2015 of 2712 lines)
  functions..: 79.8% (557 of 698 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@krisrjohnson21 krisrjohnson21 merged commit acfa18b into main Oct 18, 2023
1 check passed
@krisrjohnson21 krisrjohnson21 deleted the github-actions-krj branch October 18, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants