-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OpenTripPlanner client based on dotcom code #34
Draft
boringcactus
wants to merge
1
commit into
main
Choose a base branch
from
mth-otp-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
boringcactus
commented
Jan 10, 2024
Coverage of commit
|
boringcactus
force-pushed
the
mth-otp-client
branch
2 times, most recently
from
January 23, 2024 17:46
716b9d6
to
993cd99
Compare
boringcactus
force-pushed
the
mth-otp-client
branch
from
January 23, 2024 17:49
993cd99
to
f70d280
Compare
Coverage of commit
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there are some pieces of at least the logging that would benefit from a bit more attention than I've given them so far.
Removes Swoosh because of Req version conflicts with AbsintheClient, as mentioned in Slack.
Does not yet incorporate the parameter changes that are suggested in the explainable properties writeup. Does, however, include the suggested tags there.