Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OpenTripPlanner client based on dotcom code #34

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boringcactus
Copy link
Member

I think there are some pieces of at least the logging that would benefit from a bit more attention than I've given them so far.

Removes Swoosh because of Req version conflicts with AbsintheClient, as mentioned in Slack.

Does not yet incorporate the parameter changes that are suggested in the explainable properties writeup. Does, however, include the suggested tags there.

Copy link

Coverage of commit c59cf36

Summary coverage rate:
  lines......: 60.1% (622 of 1035 lines)
  functions..: 56.9% (310 of 545 functions)
  branches...: no data found

Files changed coverage rate:
                                                                |Lines       |Functions  |Branches    
  Filename                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================
  lib/mobile_app_backend_web/router.ex                          |80.0%     10|71.4%    14|    -      0
  lib/open_trip_planner_client.ex                               | 100%     27| 100%     5|    -      0
  lib/open_trip_planner_client/itinerary.ex                     |72.7%     11|63.6%    11|    -      0
  lib/open_trip_planner_client/itinerary_tag.ex                 | 100%     10| 100%     1|    -      0
  lib/open_trip_planner_client/itinerary_tag/earliest_arrival.ex| 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/itinerary_tag/least_walking.ex   | 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/itinerary_tag/shortest_trip.ex   | 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/leg.ex                           |83.3%      6| 100%     4|    -      0
  lib/open_trip_planner_client/named_position.ex                | 100%      1| 100%     2|    -      0
  lib/open_trip_planner_client/params_builder.ex                |96.3%     27| 100%     4|    -      0
  lib/open_trip_planner_client/parser.ex                        |64.3%     42| 100%    12|    -      0
  lib/open_trip_planner_client/personal_detail.ex               | 100%      2| 100%     2|    -      0
  lib/open_trip_planner_client/transit_detail.ex                | 100%      1| 100%     2|    -      0
  test/support/open_trip_planner_client.ex                      | 100%     20| 100%     7|    -      0

Download coverage report

Copy link

Coverage of commit 2d7fa3d

Summary coverage rate:
  lines......: 60.1% (621 of 1034 lines)
  functions..: 56.9% (310 of 545 functions)
  branches...: no data found

Files changed coverage rate:
                                                                |Lines       |Functions  |Branches    
  Filename                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================
  lib/mobile_app_backend_web/router.ex                          |80.0%     10|71.4%    14|    -      0
  lib/open_trip_planner_client.ex                               | 100%     26| 100%     5|    -      0
  lib/open_trip_planner_client/itinerary.ex                     |72.7%     11|63.6%    11|    -      0
  lib/open_trip_planner_client/itinerary_tag.ex                 | 100%     10| 100%     1|    -      0
  lib/open_trip_planner_client/itinerary_tag/earliest_arrival.ex| 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/itinerary_tag/least_walking.ex   | 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/itinerary_tag/shortest_trip.ex   | 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/leg.ex                           |83.3%      6| 100%     4|    -      0
  lib/open_trip_planner_client/named_position.ex                | 100%      1| 100%     2|    -      0
  lib/open_trip_planner_client/params_builder.ex                |96.3%     27| 100%     4|    -      0
  lib/open_trip_planner_client/parser.ex                        |64.3%     42| 100%    12|    -      0
  lib/open_trip_planner_client/personal_detail.ex               | 100%      2| 100%     2|    -      0
  lib/open_trip_planner_client/transit_detail.ex                | 100%      1| 100%     2|    -      0
  test/support/open_trip_planner_client.ex                      | 100%     20| 100%     7|    -      0

Download coverage report

@boringcactus boringcactus force-pushed the mth-otp-client branch 2 times, most recently from 716b9d6 to 993cd99 Compare January 23, 2024 17:46
Copy link

Coverage of commit f70d280

Summary coverage rate:
  lines......: 60.0% (261 of 435 lines)
  functions..: 55.4% (129 of 233 functions)
  branches...: no data found

Files changed coverage rate:
                                                                |Lines       |Functions  |Branches    
  Filename                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================
  lib/open_trip_planner_client.ex                               | 100%     26| 100%     5|    -      0
  lib/open_trip_planner_client/itinerary.ex                     |72.7%     11|63.6%    11|    -      0
  lib/open_trip_planner_client/itinerary_tag.ex                 | 100%     10| 100%     1|    -      0
  lib/open_trip_planner_client/itinerary_tag/earliest_arrival.ex| 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/itinerary_tag/least_walking.ex   | 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/itinerary_tag/shortest_trip.ex   | 100%      3| 100%     3|    -      0
  lib/open_trip_planner_client/leg.ex                           |83.3%      6| 100%     4|    -      0
  lib/open_trip_planner_client/named_position.ex                | 100%      1| 100%     2|    -      0
  lib/open_trip_planner_client/params_builder.ex                |96.3%     27| 100%     4|    -      0
  lib/open_trip_planner_client/parser.ex                        |64.3%     42| 100%    12|    -      0
  lib/open_trip_planner_client/personal_detail.ex               | 100%      2| 100%     2|    -      0
  lib/open_trip_planner_client/transit_detail.ex                | 100%      1| 100%     2|    -      0
  test/support/open_trip_planner_client.ex                      | 100%     20| 100%     7|    -      0

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants