Centralized CMS caching 1 #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
commented
Dec 16, 2023
Comment on lines
+54
to
+55
| {:nebulex, "2.5.2"}, | ||
| {:nebulex_redis_adapter, "2.3.1"}, |
There was a problem hiding this comment.
These are the only two new deps. Everything else is just alphabetization.
anthonyshull
commented
Dec 16, 2023
anthonyshull
changed the title
anthonyshull
force-pushed
the
ags/centralized-cms-caching-1
branch
from
f4a6af9 to
fa35d5a
Compare
kotva006
reviewed
Dec 19, 2023
kotva006
reviewed
Dec 19, 2023
kotva006
reviewed
Dec 19, 2023
kotva006
reviewed
Dec 19, 2023
kotva006
reviewed
Dec 19, 2023
kotva006
approved these changes
Dec 19, 2023
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
paulswartz
previously requested changes
Dec 19, 2023
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
paulswartz
reviewed
Dec 20, 2023
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Error
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Failure
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
anthonyshull
had a problem deploying
to
dev-blue
GitHub Actions
Error
anthonyshull
temporarily deployed
to
dev-blue
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to prove that a Redis connection has been made. It accepts requests to
/cms/foo/bar(which will be made by the CMS). If it can connect to Redis, it will delete the corresponding key and log a notice. If it cannot connect to Redis, it will log a warning. It returns a 202 to the requestor regardless. Ergo, we'll know whether or not Redis is running, but incur no risk.https://app.asana.com/0/555089885850811/1206129599937934/f