Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump credo from 1.7.0 to 1.7.2 #333

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 25, 2023

Bumps credo from 1.7.0 to 1.7.2.

Changelog

Sourced from credo's changelog.

1.7.2

  • Fix compatibility & compiler warnings with Elixir 1.16
  • Fix a bottleneck in multicore performance
  • Cache scope priorities
  • CHANGELOG.md is now included in the package
  • Credo.Check.Readability.NestedFunctionCalls no longer warns on function calls in interpolated strings
  • Credo.Check.Readability.PredicateFunctionNames fixed false positives
  • Credo.Check.Readability.RedundantBlankLines fixed a bug with double quotes multiline strings
  • Credo.Check.Refactor.ModuleDependencies now takes modules for :excluded_namespaces parameter
  • Credo.Check.Refactor.NegatedIsNil no longer leaks memory
  • Credo.Check.Warning.Dbg now warns when part of a pipeline and called without parens
  • Credo.Check.Warning.MissedMetadataKeyInLoggerConfig received various fixes and improvements

1.7.1

  • Fix compatibility & compiler warnings with Elixir 1.15
  • Improve docs
  • Credo.Check.Readability.Specs works for parensless definitions
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [credo](https://github.com/rrrene/credo) from 1.7.0 to 1.7.2.
- [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rrrene/credo/commits)

---
updated-dependencies:
- dependency-name: credo
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 25, 2023
@paulswartz paulswartz requested review from a team and dks-mbta and removed request for a team December 28, 2023 17:56
@paulswartz
Copy link
Member

Assigning for review as I added some code updates to address Credo warnings.

Copy link

Coverage of commit 26fd18d

Summary coverage rate:
  lines......: 93.1% (1395 of 1499 lines)
  functions..: 80.6% (449 of 557 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate.ex                                                |83.3%     66|93.8%    16|    -      0
  lib/concentrate/group_filter/remove_uncertain_stop_time_updates.ex|75.0%      8|66.7%     3|    -      0

Download coverage report

In particular, `AliasOrder` should have been the default before, but for
whatever reason in #167 it was set to `false`.
@paulswartz paulswartz force-pushed the dependabot/hex/credo-1.7.2 branch from 26fd18d to 3c3ca6a Compare December 28, 2023 21:34
Copy link

Coverage of commit 3c3ca6a

Summary coverage rate:
  lines......: 93.1% (1395 of 1499 lines)
  functions..: 80.6% (449 of 557 functions)
  branches...: no data found

Files changed coverage rate:
                                                                    |Lines       |Functions  |Branches    
  Filename                                                          |Rate     Num|Rate    Num|Rate     Num
  ========================================================================================================
  lib/concentrate.ex                                                |83.3%     66|93.8%    16|    -      0
  lib/concentrate/group_filter/remove_uncertain_stop_time_updates.ex|75.0%      8|66.7%     3|    -      0

Download coverage report

@paulswartz paulswartz merged commit f5d0fa4 into master Jan 3, 2024
3 checks passed
@paulswartz paulswartz deleted the dependabot/hex/credo-1.7.2 branch January 3, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants