Upgrade pdfjs to version 4 -- On hold till better browser support exists #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleider
reviewed
Mar 21, 2024
| } | ||
| overrides: [{ | ||
| files: ["*.ts", "*.tsx"], | ||
| parserOptions: { |
There was a problem hiding this comment.
Its hard to tell whats going on in this file since so much was moved around but previously we were setting parserOptions for the whole linting project and now its only in this overrides section?
There was a problem hiding this comment.
Basically since we have a couple regular .js files and our entire linting architecture was set up to only lint typescript, I moved the ts specific stuff to overrides so that we could lint the whole project including files that weren't in the tsconfig files (including js files in the tsconfig can lead to some messy issues)
Comment on lines
+9
to
+12
| /playwright-report/ | ||
| /blob-report/ | ||
| /playwright/.cache/ |
| @@ -8,9 +8,9 @@ | |||
| "jsx": "react", | |||
| "lib": [ | |||
| "dom", | |||
| "es2015" | |||
| "ESNext" | |||
There was a problem hiding this comment.
Did you confirm that pdfjs is building for this ES level?
jleider
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades pdfjs-dist to version 4. This includes building to
ESNextinstead ofES2015and removing theCommonJSbuild entirely. Also includes the following changes for development (shouldn't impact library usage):npm run serve-exampleand navigating to http://localhost:8080/viewer.html