Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to go111 #1

Merged
merged 1 commit into from
Mar 17, 2020
Merged

port to go111 #1

merged 1 commit into from
Mar 17, 2020

Conversation

mblakele
Copy link
Owner

The original project has been archived. But I'm creating it as an FYI for @mjibson, and maybe it will help anyone else who wants to keep goread running past 2020-03-31, when google has announced EOL for apps running on versions of go prior to 1.11

While porting, I found it expedient to rip out support for the miniprofiler. I also converted datastore log entries to log.* calls, to reduce datastore usage. Sorry about that.

I also included some minor UI changes from my fork.

These changes have been running for a few days on my personal site: so far so good.

@mblakele mblakele self-assigned this Mar 17, 2020
@mblakele mblakele force-pushed the mblakele-dev-go111 branch from ffe05ec to 068e16f Compare March 17, 2020 00:44
@mblakele mblakele changed the base branch from master to mblakele-dev March 17, 2020 00:47
@mblakele mblakele changed the base branch from mblakele-dev to master March 17, 2020 00:49
@mblakele mblakele merged commit e492a53 into master Mar 17, 2020
@mblakele mblakele deleted the mblakele-dev-go111 branch March 17, 2020 00:50
@mblakele
Copy link
Owner Author

@harishjp FYI — just saw maddyblue#351

@harishjp
Copy link

Thanks @mblakele. I suppose this is better change.

  • I was looking at logs cleanup, this eliminates the cleanup.
  • And you have moved to request.Context, when I tried it was giving me errors in datastore read and write.

@mblakele
Copy link
Owner Author

Thanks @mblakele. I suppose this is better change.

Feel free to use any of my changes. I see some things I like in your PR too. For example you didn't have to remove mpg. I may go back and revisit that.

@fredcy
Copy link

fredcy commented Jun 9, 2020

Thanks for this. I hope to continue using goread via my own app. But I can't seem to build using go 1.12. I get errors like this:

package code.google.com/p/go-charset/charset: unrecognized import path "code.google.com/p/go-charset/charset" (parse https://code.google.com/p/go-charset/charset?go-get=1: no go-import meta tags ())
package code.google.com/p/go-charset/data: unrecognized import path "code.google.com/p/go-charset/data" (parse https://code.google.com/p/go-charset/data?go-get=1: no go-import meta tags ())

I get the same when I use go 1.11.9. Any suggestions? Is there a better place to discuss this?

@mblakele
Copy link
Owner Author

mblakele commented Jun 9, 2020

Thanks for this. I hope to continue using goread via my own app. But I can't seem to build using go 1.12. I get errors like this:

package code.google.com/p/go-charset/charset: unrecognized import path "code.google.com/p/go-charset/charset" (parse https://code.google.com/p/go-charset/charset?go-get=1: no go-import meta tags ())
package code.google.com/p/go-charset/data: unrecognized import path "code.google.com/p/go-charset/data" (parse https://code.google.com/p/go-charset/data?go-get=1: no go-import meta tags ())

I get the same when I use go 1.11.9. Any suggestions? Is there a better place to discuss this?

Following up here: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants