Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to control color of each character #235

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mheidarian
Copy link
Contributor

No description provided.

@mbi mbi merged commit 7ca5498 into mbi:master Nov 14, 2024
5 checks passed
@mbi
Copy link
Owner

mbi commented Nov 14, 2024

Awesome, thank you! I just changed a tiny detail, i.e. the documentation of the CAPTCHA_LETTER_COLOR_FUNCT setting states that the second argument is the whole challenge string, when in reality you were only passing the current letter in the loop.

I changed it so that it actually does as mentioned in the documentation, which makes more sense since we're also passing the index. I imagine this was your original intention?

@mheidarian
Copy link
Contributor Author

Awesome, thank you! I just changed a tiny detail, i.e. the documentation of the CAPTCHA_LETTER_COLOR_FUNCT setting states that the second argument is the whole challenge string, when in reality you were only passing the current letter in the loop.

I changed it so that it actually does as mentioned in the documentation, which makes more sense since we're also passing the index. I imagine this was your original intention?

Yes, that was indeed my original intention. Thank you for catching and correcting it! I appreciate your attention to detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants