Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update pylint requirement from ~=2.17 to ~=3.1 #17

Merged
merged 1 commit into from
May 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 3, 2024

Updates the requirements on pylint to permit the latest version.

Commits
  • 053c2c3 Bump pylint to 3.1.0, update changelog
  • c954636 Upgrade release documentation, and contributors.txt
  • 7300ed2 Discover .pyi files (#9241)
  • 9dbf3df Merge maintenance 3.0.x into main following 3.0.4 release (#9459)
  • 28e89b0 Remove changelog fragments pertaining to 3.0.4
  • 4332ea1 Merge branch 'maintenance/3.0.x' into main following 3.0.4 release
  • 8115381 Bump pylint to 3.0.4, update changelog (#9458)
  • 4bf3524 [false-negative] Fix for consider-using-min/max-builtin (#9127)
  • 8c24b1e [pre-commit.ci] pre-commit autoupdate (#9448)
  • f499686 Update astroid version to 3.1.0 (#9457)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version.
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v2.17.0...v3.1.0)

---
updated-dependencies:
- dependency-name: pylint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Apr 3, 2024
@jenkins-mbdev
Copy link

jenkins-mbdev bot commented Apr 3, 2024

Tools report for GitHub-mbdevpl/version-query/PR-17 [build #1]:

  • Pylint: warnings ⚠️ (click for details)
    ************* Module version_query.git_query
    version_query/git_query.py:76:0: R1260: '_latest_git_version_tag' is too complex. The McCabe rating is 12 (too-complex)
    ************* Module version_query.version
    version_query/version.py:244:4: R1260: '_get_pre_release_from_args' is too complex. The McCabe rating is 11 (too-complex)
    version_query/version.py:22:4: C0103: Class constant name "Major" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:23:4: C0103: Class constant name "Minor" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:24:4: C0103: Class constant name "Patch" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:25:4: C0103: Class constant name "Release" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:26:4: C0103: Class constant name "PrePatch" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:27:4: C0103: Class constant name "DevPatch" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:28:4: C0103: Class constant name "Local" doesn't conform to UPPER_CASE naming style (invalid-name)
    version_query/version.py:32:11: R1729: Use a generator instead 'all(_ is not None if flag else _ is None for (_, flag) in zip(version_tuple, flags))' (use-a-generator)
    version_query/version.py:35:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)
    version_query/version.py:77:28: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
    version_query/version.py:108:15: R1728: Consider using a generator instead 'tuple(_ for _ in match.groups() if _ is not None)' (consider-using-generator)
    version_query/version.py:111:22: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
    version_query/version.py:113:16: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
    version_query/version.py:150:14: W0212: Access to a protected member _version of a client class (protected-access)
    version_query/version.py:203:4: R0913: Too many arguments (6/5) (too-many-arguments)
    version_query/version.py:203:4: W1113: Keyword argument before variable positional arguments list in the definition of __init__ function (keyword-arg-before-vararg)
    version_query/version.py:504:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
    version_query/version.py:508:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
    version_query/version.py:510:19: C0209: Formatting a regular string which could be an f-string (consider-using-f-string)
    ************* Module test.test_version
    test/test_version.py:134:12: R0204: Redefinition of version.release type from int to tuple (redefined-variable-type)
    
    -----------------------------------
    Your code has been rated at 9.82/10
    
  • Mypy: problems ⚠️ (click for details)
    version_query/version.py:135: error: Argument "pre_release" to "Version" has incompatible type "Sequence[tuple[str | None, str | None, int | None]] | None"; expected "Sequence[tuple[str | None, str | None, int | None]]"  [arg-type]
    version_query/version.py:135: error: Argument "local" to "Version" has incompatible type "tuple[Any, ...] | None"; expected "str | tuple[Any, ...]"  [arg-type]
    version_query/version.py:169: error: Incompatible types in assignment (expression has type "tuple[str, int]", variable has type "tuple[None, int] | None")  [assignment]
    version_query/version.py:171: error: Incompatible types in assignment (expression has type "tuple[str, int]", variable has type "tuple[None, int] | None")  [assignment]
    version_query/version.py:179: error: Argument 1 to "Version" has incompatible type "int | None"; expected "int"  [arg-type]
    version_query/version.py:179: error: Argument "pre_release" to "Version" has incompatible type "Sequence[tuple[str | None, str | None, int | None]] | None"; expected "Sequence[tuple[str | None, str | None, int | None]]"  [arg-type]
    version_query/version.py:179: error: Argument "local" to "Version" has incompatible type "tuple[str, ...] | None"; expected "str | tuple[Any, ...]"  [arg-type]
    version_query/version.py:197: error: Argument "pre_release" to "Version" has incompatible type "None"; expected "Sequence[tuple[str | None, str | None, int | None]]"  [arg-type]
    version_query/version.py:206: error: Incompatible default for argument "pre_release" (default has type "None", argument has type "Sequence[tuple[str | None, str | None, int | None]]")  [assignment]
    version_query/version.py:206: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    version_query/version.py:206: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    version_query/version.py:207: error: Incompatible default for argument "local" (default has type "None", argument has type "str | tuple[Any, ...]")  [assignment]
    version_query/version.py:207: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
    version_query/version.py:207: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
    version_query/version.py:273: error: Argument 1 to "append" of "list" has incompatible type "tuple[int | str, ...]"; expected "tuple[str | None, str | None, int | None]"  [arg-type]
    version_query/version.py:552: error: Incompatible return value type (got "Sequence[Any]", expected "tuple[Any, ...]")  [return-value]
    test/test_version.py:27: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
    test/test_version.py:35: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
    test/test_version.py:79: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
    Found 12 errors in 1 file (checked 15 source files)
    
  • Flake518: ran 🆗

  • Pydocstyle: ran 🆗

  • Coverage: 98% 🆗 (click for details)
    Name                         Stmts   Miss Branch BrPart  Cover   Missing
    ------------------------------------------------------------------------
    setup.py                        11      0      2      0   100%
    test/__init__.py                 5      0      0      0   100%
    test/examples.py                49      1     18      1    97%   24
    test/test_git.py               195      0     34      0   100%
    test/test_packaging.py           3      0      0      0   100%
    test/test_query.py             161      3     69      1    98%   67, 103-104
    test/test_version.py           153      0     84      0   100%
    version_query/__init__.py        5      0      0      0   100%
    version_query/__main__.py        9      0      2      0   100%
    version_query/_version.py        2      0      0      0   100%
    version_query/git_query.py     114      1     52      1    99%   64
    version_query/main.py           21      0      6      0   100%
    version_query/py_query.py       31      5     17      1    83%   14-17, 41
    version_query/query.py          50      0      2      0   100%
    version_query/version.py       442      7    270      6    98%   139, 160, 165, 167, 194, 498, 511
    ------------------------------------------------------------------------
    TOTAL                         1251     17    556     10    98%
    

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (86cafd0) to head (bbeabe1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          15       15           
  Lines        1251     1251           
  Branches      277      277           
=======================================
  Hits         1234     1234           
  Misses          9        9           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbdevpl mbdevpl merged commit 1c5eef9 into main May 26, 2024
24 checks passed
@dependabot dependabot bot deleted the dependabot/pip/pylint-approx-eq-3.1 branch May 26, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant