Enable non-local file access on Windows #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces proper path construction to support non-local file access on Windows. While path processing works as expected, there are known issues in the logs where paths may be incorrectly represented with both forward and backslashes. These erroneous paths are not processed, but they do appear in the logs. The changes were made to ensure correct path building without deviating from the provided class objects. A future feature request should address improving log accuracy for Windows environments.
To pass CI checks of-course :)
|
I should mention on Windows I tend to map drives with say a Z:/. This is just a personal preference. So to be clear this commit was designed to handle this case; the case where we access non local files on a file server with a mapped drive interface. |
|
thanks! |
|
Cool, thanks Carlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces proper path construction to support non-local file access on Windows. While path processing works as expected, there are known issues in the logs where paths may be incorrectly represented with both forward and backslashes. These erroneous paths are not processed, but they do appear in the logs.
The changes were made to ensure correct path building without deviating from the provided class objects. A future feature request should address improving log accuracy for Windows environments.