Skip to content

Commit

Permalink
✨ 996 Implement feebdack on productlist page
Browse files Browse the repository at this point in the history
  • Loading branch information
stefrado committed Nov 15, 2024
1 parent 7ca2ba2 commit f3b7606
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 25 deletions.
5 changes: 0 additions & 5 deletions src/sdg/organisaties/views/catalogi.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ class CatalogListView(
"label": _("Naam"),
"filter_label": _("Zoek op productnaam"),
},
{
"key": "generiek_product__upn__thema__informatiegebied",
"label": _("Informatiegebied"),
"filter_label": _("Selecteer thema"),
},
{
"label": _("Aangeboden"),
"key": "product_aanwezig",
Expand Down
2 changes: 1 addition & 1 deletion src/sdg/producten/views/product.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def get_queryset(self):
)

def get_breadcrumbs_title(self):
name = capfirst(self.object)
name = capfirst(self.product)

if self.product.is_referentie_product:
return f"{name} (referentie)"
Expand Down
1 change: 1 addition & 0 deletions src/sdg/scss/components/_colors.scss
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ $color_success_notification-bg: #9fcb6266;

$color_red: #c74a4a;
$color_green: #39885d;
$color_white: #fff;

$color-bg: #f5f5f5;

Expand Down
2 changes: 1 addition & 1 deletion src/sdg/scss/components/_select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ select {
background-image: none;
cursor: pointer;
font-family: 'Source Sans Pro', sans-serif;
background-color: $color_grey_light;
background-color: $color_white;

/* Remove IE arrow */
&::-ms-expand {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


$base_with: (
'color-background': $color_grey_light,
'color-background': $color_white,
'color-info': $color_primary_lightest,
'typography-color-link': $color_primary,
'shades': (
Expand Down
4 changes: 3 additions & 1 deletion src/sdg/templates/core/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% block inner %}
{% with namespace=request.resolver_match.namespaces|last pk=lokaleoverheid.pk %}
<div class="breadcrumbs">
{{product}}
<div>
<a href="{% url 'core:home' %}">{% trans 'Homepage' %}</a>
{% with kwargs=request.resolver_match.kwargs %}
Expand All @@ -14,6 +15,7 @@
<a href="{% url 'organisaties:catalogi:list' pk=kwargs.pk %}">{% trans 'Productenlijst' %}</a>
{% endif %}
{% endwith %}

{% if breadcrumbs_title %}
<span>{{ breadcrumbs_title }}</span>
{% elif namespace == "roles" %}
Expand All @@ -31,7 +33,7 @@
</div>
<h2 class="products__title primary">
{% block page_title %}
<span>{{ object|capfirst|default:namespace|capfirst }}</span>
<span>{{ product|capfirst|default:namespace|capfirst }}</span>
{% endblock %}
</h2>
{% block page_intro %}{% endblock %}
Expand Down
6 changes: 0 additions & 6 deletions src/sdg/templates/organisaties/catalogi/list.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
{% load rijkshuisstijl_datagrid static i18n producten utils %}

{% block page_title %}{% trans "Productenlijst" %}{% endblock %}
{% block page_intro %}
<p class="subheading">
{% trans "Je ziet hieronder de lijst van alle SDG producten. Klik op een product om deze te bewerken." %}
</p>
{% endblock %}


{% block page_content %}
{% datagrid config=datagrid_config %}
Expand Down
12 changes: 2 additions & 10 deletions src/sdg/templates/producten/update.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,11 @@
{% endfor %}
{% endblock %}

{% block breadcrumbs_page_title %}
{% if product.is_referentie_product %}
<span>{{ object|capfirst|default:namespace|capfirst }} (referentie)</span>
{% else %}
<span>{{ object|capfirst|default:namespace|capfirst }}</span>
{% endif %}
{% endblock %}

{% block page_title %}
{% if product.is_referentie_product %}
<span>{{ object|capfirst|default:namespace|capfirst }} (referentie)</span>
<span>{{ product|capfirst|default:namespace|capfirst }} (referentie)</span>
{% else %}
<span>{{ object|capfirst|default:namespace|capfirst }}</span>
<span>{{ product|capfirst|default:namespace|capfirst }}</span>
{% endif %}
{% endblock %}

Expand Down

0 comments on commit f3b7606

Please sign in to comment.