-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/310 validation nummeraanduidingid #315
Merged
danielmursa-dev
merged 1 commit into
master
from
feature/310-validation-nummeraanduidingid
Jan 30, 2025
Merged
Feature/310 validation nummeraanduidingid #315
danielmursa-dev
merged 1 commit into
master
from
feature/310-validation-nummeraanduidingid
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmursa-dev
requested review from
SonnyBA,
stevenbal,
swrichards and
Coperh
January 9, 2025 11:24
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 16, 2025
stevenbal
added a commit
that referenced
this pull request
Jan 21, 2025
stevenbal
requested changes
Jan 23, 2025
...ents/contactgegevens/migrations/0004_alter_organisatie_adres_nummeraanduiding_id_and_more.py
Outdated
Show resolved
Hide resolved
...ents/contactgegevens/migrations/0004_alter_organisatie_adres_nummeraanduiding_id_and_more.py
Outdated
Show resolved
Hide resolved
...lantinteracties/migrations/0024_alter_betrokkene_bezoekadres_nummeraanduiding_id_and_more.py
Outdated
Show resolved
Hide resolved
...lantinteracties/migrations/0024_alter_betrokkene_bezoekadres_nummeraanduiding_id_and_more.py
Outdated
Show resolved
Hide resolved
@danielmursa-dev could you rebase this on #317 and change the PR to merge to that branch? That way it is easier to see the diff and review the changes :) |
danielmursa-dev
force-pushed
the
feature/310-validation-nummeraanduidingid
branch
from
January 30, 2025 11:05
604ff6e
to
6d44c46
Compare
danielmursa-dev
changed the base branch from
master
to
feature/311-validation-country-code
January 30, 2025 11:06
danielmursa-dev
force-pushed
the
feature/310-validation-nummeraanduidingid
branch
from
January 30, 2025 11:16
6d44c46
to
1a21eb9
Compare
Base automatically changed from
feature/311-validation-country-code
to
master
January 30, 2025 11:38
stevenbal
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
bag_id
-> (length=16 and only digits
)