Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/310 validation nummeraanduidingid #315

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Jan 8, 2025

Fixes #310

  • Created a regex validation for validate bag_id -> (length=16 and only digits)
  • Fixed tests

stevenbal added a commit that referenced this pull request Jan 16, 2025
stevenbal added a commit that referenced this pull request Jan 16, 2025
stevenbal added a commit that referenced this pull request Jan 16, 2025
stevenbal added a commit that referenced this pull request Jan 16, 2025
stevenbal added a commit that referenced this pull request Jan 16, 2025
stevenbal added a commit that referenced this pull request Jan 21, 2025
@swrichards swrichards removed their request for review January 23, 2025 10:45
@stevenbal
Copy link
Collaborator

@danielmursa-dev could you rebase this on #317 and change the PR to merge to that branch? That way it is easier to see the diff and review the changes :)

@danielmursa-dev danielmursa-dev force-pushed the feature/310-validation-nummeraanduidingid branch from 604ff6e to 6d44c46 Compare January 30, 2025 11:05
@danielmursa-dev danielmursa-dev changed the base branch from master to feature/311-validation-country-code January 30, 2025 11:06
[#310] Update migrations

[#310] Create tests

[#310] Fix old tests
@danielmursa-dev danielmursa-dev force-pushed the feature/310-validation-nummeraanduidingid branch from 6d44c46 to 1a21eb9 Compare January 30, 2025 11:16
Base automatically changed from feature/311-validation-country-code to master January 30, 2025 11:38
@danielmursa-dev danielmursa-dev merged commit 0ce57de into master Jan 30, 2025
23 checks passed
@danielmursa-dev danielmursa-dev deleted the feature/310-validation-nummeraanduidingid branch January 30, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAG-ID velden, korte veldlengte en validatie toepassen op inhoud
2 participants