Adding Objects API client integration #793
Conversation
Release v1.0.6
Release v1.1
v1.3 release
Release v1.4
Release v1.5
Release v1.7
Release v1.8
Release v1.9
Productionrelease v1.9.5
Release v1.10
bart-maykin
force-pushed
the
feature/1776-objects-api-integration
branch
2 times, most recently
from
506f4be to
9942955
Compare
| </h2> | ||
| <div> | ||
| {% if objects %} | ||
| {% map 52.1326 5.2913 zoom=3 geojson_feature_collection=objects %} |
There was a problem hiding this comment.
Zou nog instelbaar gemaakt kunnen worden
| {% if objects %} | ||
| {% map 52.1326 5.2913 zoom=3 geojson_feature_collection=objects %} | ||
| {% else %} | ||
| <p>Er staan geen taken gevonden</p> |
There was a problem hiding this comment.
Zou nog instelbaar gemaakt kunnen worden
|
Dank @bart-maykin voor een mooie eerste integratie van de Objecten API. @jiromaykin goed om later deze maand ter voorbereiding op NLDS integratie hier naar te kijken. Bart heeft de stijling overgenomen op basis van:
Ik twijfel nog wel wat de volgende stap hiermee wordt. We kunnen het (na wat poetsen) samenvoegen echter aangezien geen van de huidige OIP gemeenten de Objecten API gebruikt voelt het nog prematuur. @Bartvaderkin mag hier ook een blik op werpen |
Release v1.11
Bumping version for release
bart-maykin
force-pushed
the
feature/1776-objects-api-integration
branch
from
9942955 to
eaed778
Compare
bart-maykin
force-pushed
the
feature/1776-objects-api-integration
branch
from
eaed778 to
92b6365
Compare
bart-maykin
force-pushed
the
feature/1776-objects-api-integration
branch
from
92b6365 to
9ab9676
Compare
There was a problem hiding this comment.
Looks good, some small notes in the files.
Two other notes:
- Can you rebase on current development and get rid of the ancient merge commits and other old noise.
- We try to use
[#1234] Added a thing to fix that other thingcommit messages (eg: uppercase verb, no gitmoji and a useful message) - Why is this called a Den Haag action' ?
| if component := instance.component: | ||
| match component: | ||
| case ComponentChoices.link: | ||
| return "cms/objects/objects_list.html" | ||
| case ComponentChoices.map: | ||
| return "cms/objects/objects_map.html" |
There was a problem hiding this comment.
The project uses python 3.9 so no pattern matching.
| <div class="denhaag-action__content">{{title}}</div> | ||
| <div class="denhaag-action__details"> | ||
| <div class="denhaag-action__date"> | ||
| <time datetime="2023-09-28T19:47:36.593Z">{{date}}</time> |
| @@ -0,0 +1,15 @@ | |||
| {% load l10n i18n %} | |||
|
|
|||
| <a href="{{link}}" class="denhaag-action denhaag-action--single"> | |||
There was a problem hiding this comment.
Why is a lot of this namepaced as 'Den Haag'?
| from django import template | ||
|
|
||
| register = template.Library() | ||
|
|
||
|
|
||
| @register.inclusion_tag("components/DenhaagAction/DenhaagAction.html") | ||
| def denhaag_action(title, date, link, **kwargs): | ||
| kwargs["title"] = title | ||
| kwargs["date"] = date | ||
| kwargs["link"] = link | ||
| return kwargs |
There was a problem hiding this comment.
What is 'Den Haag' about this? What is a 'DenhaagAction'?
| </svg> | ||
| </div> | ||
| </div> | ||
| </a> |
There was a problem hiding this comment.
Github shows a red no-newline warning here (configure your editor to add it on save).
|
Vervangen met #1442 tijdens de afgelopen hackathon, dank Bart voor de oude PR we hebben er nuttig gebruik van weten te maken |
No description provided.