Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2940] Add OpenKlant2 configuration model #1529

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[#2940] Add OpenKlant2 configuration model #1529

merged 1 commit into from
Dec 18, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma force-pushed the task/2940-openklant2-config branch from 6ec9b9c to 739211a Compare December 16, 2024 16:45
@pi-sigma pi-sigma force-pushed the task/2940-openklant2-config branch 9 times, most recently from 6148f45 to 7a483d1 Compare December 18, 2024 11:16
swrichards
swrichards requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor points which might require attention (especially the singleton issue).

src/open_inwoner/openklant/models.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/models.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/tests/test_openklant2_service.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_case_detail.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/services.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/models.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/models.py Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the task/2940-openklant2-config branch 2 times, most recently from 801f58d to 601f259 Compare December 18, 2024 13:33
@pi-sigma pi-sigma marked this pull request as ready for review December 18, 2024 13:56
@pi-sigma pi-sigma requested a review from swrichards December 18, 2024 13:57
swrichards
swrichards requested changes Dec 18, 2024
View reviewed changes
src/open_inwoner/openzaak/tests/test_cases.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/tests/factories.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/tests/data.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/tests/test_oidc_views.py Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the task/2940-openklant2-config branch 2 times, most recently from 80dc115 to 2607df8 Compare December 18, 2024 15:15
@pi-sigma pi-sigma force-pushed the task/2940-openklant2-config branch 2 times, most recently from 52e2c99 to 3aa271f Compare December 18, 2024 15:52
@pi-sigma pi-sigma force-pushed the task/2940-openklant2-config branch from 3aa271f to 09dc738 Compare December 18, 2024 16:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.12%. Comparing base (0d4c736) to head (09dc738).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/models.py 84.61% 2 Missing ⚠️
src/open_inwoner/openklant/services.py 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1529      +/-   ##
===========================================
- Coverage    94.13%   94.12%   -0.01%     
===========================================
  Files         1063     1064       +1     
  Lines        39205    39204       -1     
===========================================
- Hits         36904    36901       -3     
- Misses        2301     2303       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards self-requested a review December 18, 2024 17:03
@swrichards swrichards requested a review from alextreme December 18, 2024 17:03
@alextreme alextreme merged commit 2429bd2 into develop Dec 18, 2024
20 checks passed
@alextreme alextreme deleted the task/2940-openklant2-config branch December 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @alextreme @swrichards