Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#498 frontend prepopulate #523

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Nov 27, 2024

closes #498

PENDING: E2E Test

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (1d04890) to head (0fd3ad3).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/lib/api/destructionListsItem.ts 0.00% 4 Missing ⚠️
frontend/src/hooks/useZaakReviewStatusBadges.tsx 66.66% 1 Missing ⚠️
...s/destructionlist/review/DestructionListReview.tsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   79.84%   79.90%   +0.06%     
==========================================
  Files         199      201       +2     
  Lines        5472     5504      +32     
  Branches      554      556       +2     
==========================================
+ Hits         4369     4398      +29     
- Misses       1103     1106       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xaohs Xaohs force-pushed the issue/#498-frontend-prepopulate branch from 122c24f to 7c84145 Compare November 27, 2024 14:08
@Xaohs Xaohs marked this pull request as ready for review November 27, 2024 14:56
@Xaohs Xaohs requested review from SilviaAmAm and svenvandescheur and removed request for SilviaAmAm November 27, 2024 14:56
Copy link
Contributor

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remarks, also: can we add a textural/visual indication that the case needs to be re-reviewed? I prototyped something real quick:

Scherm­afbeelding 2024-11-29 om 10 39 02

@Xaohs
Copy link
Contributor Author

Xaohs commented Dec 3, 2024

image

@svenvandescheur
Copy link
Contributor

Try <Outline.ArrowPathRoundedSquareIcon/> as icon, looks good otherwise 👍

@svenvandescheur svenvandescheur self-requested a review December 3, 2024 15:23
@Xaohs Xaohs merged commit 29e81e7 into main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kunnen zien van welke zaken na beoordeling uitzondering van vernietiging niet is overgenomen
3 participants