✨ - landing page implementation #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2024 16:36
author Julian Roeland <[email protected]> 1715942902 +0200 committer Julian Roeland <[email protected]> 1716561398 +0200 :sparkles: - landing page implementation
Xaohs
force-pushed
the
feature/#17-landing-page
branch
from
16b8480 to
72af35b
Compare
SilviaAmAm
reviewed
May 27, 2024
|
One thing I forgot to mention: from the kanban page it should be possible to click on the destruction list and navigate to its detail page. |
SilviaAmAm
reviewed
May 30, 2024
| title: deslugify(status), | ||
| items: constructComponentList(lists[status]), | ||
| componentList: STATUSES.map((status) => ({ | ||
| title: STATUS_LABELS[status] || deslugify(status), |
There was a problem hiding this comment.
Is the or needed? Since it is hardcoded, we know that we have a label. Then we don't need to maintain the deslugify function 😄
There was a problem hiding this comment.
I'm a little bit surprised seeing api changes for the kanban as i expected only a minimal change. Also I don't see componentList in @maykin-ui/admin-ui, is it missing a pr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.