💚 #636 - test: attempt to fix the tests

maykinmedia · Jan 27, 2025 · 1474a12 · 1474a12
1 parent 68b276e
commit 1474a12
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/backend/src/openarchiefbeheer/utils/tests/gherkin.py b/backend/src/openarchiefbeheer/utils/tests/gherkin.py
@@ -699,6 +699,7 @@ async def list_should_have_user_in_assignees(
             self, page, destruction_list, assignee
         ):
             await destruction_list.arefresh_from_db()
+            await page.wait_for_timeout(300)  # Attempt to fix random CI issues
             list_assignee = await destruction_list.assignees.aget(pk=assignee.pk)
             self.testcase.assertTrue(list_assignee)
 

diff --git a/frontend/src/components/DestructionListReviewer/DestructionListReviewer.stories.tsx b/frontend/src/components/DestructionListReviewer/DestructionListReviewer.stories.tsx
@@ -525,7 +525,7 @@ export const ReassignDestructionListErrorShowsErrorMessage: Story = {
 
     const dialog = await canvas.findByRole("dialog");
 
-    const beoordelaar = await canvas.findByLabelText("Beoordelaar");
+    const beoordelaar = await canvas.findByLabelText("Beoordelaar*");
     await userEvent.click(beoordelaar, { delay: 10 });
     const options = await within(dialog).findAllByText(
       "Beoor del Laar 2 (Beoor del Laar 2)",

diff --git a/frontend/src/components/DestructionListToolbar/DestructionListToolbar.stories.tsx b/frontend/src/components/DestructionListToolbar/DestructionListToolbar.stories.tsx
@@ -183,7 +183,9 @@ export const Tabable: Story = {
   },
   play: async (context) => {
     const canvas = within(context.canvasElement);
-    await expect(canvas.getByText("Auteur")).toBeVisible();
+    await expect(
+      canvas.getByText("Min/max archiefactiedatum"),
+    ).not.toBeVisible();
     await userEvent.click(
       await canvas.findByRole("tab", { name: "Geschiedenis" }),
     );

diff --git a/frontend/src/lib/api/coReview.test.ts b/frontend/src/lib/api/coReview.test.ts
@@ -1,8 +1,6 @@
-import { expect } from "@storybook/test";
 import fetchMock from "jest-fetch-mock";
 
-import { coReviewFactory } from "../../fixtures/coReview";
-import { destructionListFactory } from "../../fixtures/destructionList";
+import { coReviewFactory, destructionListFactory } from "../../fixtures";
 import { createCoReview, listCoReviews } from "./coReview";
 
 describe("coReview", () => {