-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨[#64] add subgroup to generate_envvar_docs #71
base: main
Are you sure you want to change the base?
Conversation
98ce9a5
to
6b932fe
Compare
Do you think this is fine or should I try to implement the automatic help text retriever from setup config? Not sure how this would be possible since envvars are not linked to the setup steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested it briefly with Open Klant and it works.
The only thing I'm not sure about is how we fit in the general documentation about setup configuration. The current docs for OZ for example describe how the command can be used and also has one or two sentences to describe what each step does: https://github.com/open-zaak/open-zaak/blob/main/docs/installation/config/openzaak_config_cli.rst#open-zaak-configuration-cli.
I'm not sure if grouping setup-configuration envvars together with all the other environment vars is the right way to go, also because the former are more of a one time thing to set things up, while the "regular" envvars can be modified to directly change configuration.
@annashamray what do you think?
a91a8ae
to
a35a001
Compare
a35a001
to
c8eb4db
Compare
Fixes #64