Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/django setup configuration mozilla django OIDC db #136

Merged

Conversation

danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Dec 10, 2024

Fixes maykinmedia/objects-api#480

  • Configuration mozilla
  • New configuration Site

@SonnyBA
Copy link
Contributor

SonnyBA commented Dec 11, 2024

@danielmursa-dev could you rebase from #135? That will make the git history clearer.

@SonnyBA
Copy link
Contributor

SonnyBA commented Dec 11, 2024

Commenting this link to make reviewing a bit easier for now

@danielmursa-dev danielmursa-dev force-pushed the issue/django-setup-configuration-mozilla-django-oidc-db branch from a69457d to 8206383 Compare December 11, 2024 13:25
Copy link
Contributor

@SonnyBA SonnyBA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but lets wait until #135 is merged. Could you also update the documentation and a small section which shows an example of a configuration?

@danielmursa-dev danielmursa-dev force-pushed the issue/django-setup-configuration-mozilla-django-oidc-db branch 2 times, most recently from 932322a to e3f043d Compare December 13, 2024 15:22
@danielmursa-dev danielmursa-dev force-pushed the issue/django-setup-configuration-mozilla-django-oidc-db branch from 0401712 to 646dd1c Compare December 13, 2024 15:37
Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine I think. This was reviewed on my phone though

@danielmursa-dev danielmursa-dev merged commit 3181a5b into master Dec 17, 2024
13 checks passed
@danielmursa-dev danielmursa-dev deleted the issue/django-setup-configuration-mozilla-django-oidc-db branch December 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Admin-OIDC configuration via django-setup-configuration
4 participants