[#21] display version in admin #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coperh
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Similar situation as mentioned in this comment: open-zaak/open-notificaties#155 (comment)
|
Please rebase on master, quick-start action is fixed there |
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
2 times, most recently
from
e7ba886 to
6a8cf5c
Compare
stevenbal
requested changes
Jun 21, 2024
| @@ -36,6 +36,12 @@ DO NOT PUT ANY TARGET APP-SPECIFIC RULES HERE. | |||
|
|
|||
| --object-tools-bg: #888; | |||
| --object-tools-hover-bg: #{$color_dark}; | |||
|
|
|||
| // version styling | |||
| --version-fg: #{$color-secondary-dark}; | |||
There was a problem hiding this comment.
Maybe we should make this a bit darker? It's not very readable imo
There was a problem hiding this comment.
Now that it reuses another variable (same as the welcome message):
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
from
c006fd4 to
a6f0325
Compare
Coperh
reviewed
Jun 21, 2024
stevenbal
approved these changes
Jun 21, 2024
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
from
f6522db to
5ca35b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes maykinmedia/open-api-framework#21 :