[#513] Release 3.0.0 #517

SonnyBA · 2025-01-09T15:25:39Z

Partially fixes #513

Changes

Adds changes required for releasing 3.0.0. This is the major release part.

Release/2.4.4

SonnyBA · 2025-01-09T15:27:54Z

docs/api/index.rst

-`Objecttypes API`_      2.0.0 (
-                        `Redoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.0.0/src/objecttypes/api/v2/openapi.yaml>`__,
-                        `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.0.0/src/objecttypes/api/v2/openapi.yaml>`__
+`Objecttypes API`_      2.2.2 (


This applies here too

I don't think it should refer to an unreleased objecttypes but if objecttypes is released first, then I say it should.

Also, should it referrer to Objecttypes 3.0.0 since that will remove also removed API V1

I'm not sure if the specification version matches the application version necessarily (see my comment at maykinmedia/objecttypes-api#149 (comment))

As this version number refers to the specification version, we could refer here to the latest specification version (2.0.0 in this case?) and use the link of the latest application openapi specification (that of 3.0.0) so that we don't link people to older openapi specifications 🤔

src/objects/conf/api.py

Coperh

Looks good

Coperh · 2025-01-10T10:22:01Z

docs/api/index.rst

-`Objecttypes API`_      2.0.0 (
-                        `Redoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.0.0/src/objecttypes/api/v2/openapi.yaml>`__,
-                        `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.0.0/src/objecttypes/api/v2/openapi.yaml>`__
+`Objecttypes API`_      2.2.2 (


I don't think it should refer to an unreleased objecttypes but if objecttypes is released first, then I say it should.

Also, should it referrer to Objecttypes 3.0.0 since that will remove also removed API V1

Coperh · 2025-01-10T10:28:09Z

With this, are we removing support for Objecttypes-api < 3.0.0?

CHANGELOG.rst

README.NL.rst

stevenbal · 2025-01-10T15:53:47Z

docs/api/index.rst

-`Objecttypes API`_      2.0.0 (
-                        `Redoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.0.0/src/objecttypes/api/v2/openapi.yaml>`__,
-                        `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objecttypes-api/2.0.0/src/objecttypes/api/v2/openapi.yaml>`__
+`Objecttypes API`_      2.2.2 (


I'm not sure if the specification version matches the application version necessarily (see my comment at maykinmedia/objecttypes-api#149 (comment))

package-lock.json

publiccode.yaml

src/objects/conf/api.py

stevenbal

Just the question remaining about the listed API spec versions in the readme, but since that seems to be incorrect on main already, I won't let it block this release

stevenbal · 2025-01-16T08:21:05Z

README.NL.rst

@@ -38,7 +38,16 @@ Versie          Release datum   API specificatie
 ==============  ==============  =============================
 latest          n/a             `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/master/src/objects/api/v2/openapi.yaml>`_,
                                `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/master/src/objects/api/v2/openapi.yaml>`_,
-                                (`verschillen <https://github.com/maykinmedia/objects-api/compare/2.4.3..master#diff-b9c28fec6c3f3fa5cff870d24601d6ab7027520f3b084cc767aefd258cb8c40a>`_)
+                                (`verschillen <https://github.com/maykinmedia/objects-api/compare/3.0.0..master>`_)


Same comment as here: https://github.com/maykinmedia/objecttypes-api/pull/149/files#r1917934515

stevenbal · 2025-01-16T08:21:37Z

README.NL.rst

@@ -38,7 +38,16 @@ Versie          Release datum   API specificatie
 ==============  ==============  =============================
 latest          n/a             `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/master/src/objects/api/v2/openapi.yaml>`_,
                                `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/master/src/objects/api/v2/openapi.yaml>`_,
-                                (`verschillen <https://github.com/maykinmedia/objects-api/compare/2.4.3..master#diff-b9c28fec6c3f3fa5cff870d24601d6ab7027520f3b084cc767aefd258cb8c40a>`_)
+                                (`verschillen <https://github.com/maykinmedia/objects-api/compare/3.0.0..master>`_)
+3.0.0           2025-01-14      `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,


Reminder to change this date to when it's going to be released

Suggested change

3.0.0 2025-01-14 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,

3.0.0 2025-01-16 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,

stevenbal · 2025-01-16T08:21:48Z

README.rst

@@ -36,10 +36,19 @@ Version         Release date    API specification
 ==============  ==============  =============================
 latest          n/a             `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/master/src/objects/api/v2/openapi.yaml>`_,
                                `Swagger <https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/master/src/objects/api/v2/openapi.yaml>`_,
-                                (`diff <https://github.com/maykinmedia/objects-api/compare/2.4.3..master#diff-b9c28fec6c3f3fa5cff870d24601d6ab7027520f3b084cc767aefd258cb8c40a>`_)
+                                (`diff <https://github.com/maykinmedia/objects-api/compare/3.0.0..master>`_)
+3.0.0           2025-01-14      `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,


Reminder to change this date to when it's going to be released

Suggested change

3.0.0 2025-01-14 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,

3.0.0 2025-01-16 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,

stevenbal · 2025-01-16T08:22:17Z

publiccode.yaml

-softwareVersion: 2.4.3
-releaseDate: '2021-01-13'
+softwareVersion: 3.0.0
+releaseDate: '2025-01-14'


Reminder to change this when it's released

stevenbal · 2025-01-16T08:22:59Z

CHANGELOG.rst

-2.x.x
-=====
-*TBD*
+3.0.0 (2025-01-14)


Reminder to change this when it's released

Hugo-ter-Doest · 2025-01-16T15:09:50Z

This is not breaking for OF, ZAC, KISS, OIP, ABC. I checked this with the PO's.

annashamray and others added 8 commits January 9, 2025 15:38

Merge pull request #462 from maykinmedia/release/2.4.4

c64e8cf

Release/2.4.4

[#513] Update changelog & README

e73a0f4

[#513] bump version for various files

547c07e

[#513] update CHANGELOG & bump version for various files

faec711

[#513] use more fine-grained search & replace for README's

549d168

[#513] undo requirements changes

2068f10

[#513] remove previously VERSIONS setting

00291d3

[#513] regenerate openapi spec

adc7519

SonnyBA commented Jan 9, 2025

View reviewed changes

SonnyBA self-assigned this Jan 9, 2025

SonnyBA requested review from joeribekker, Coperh and stevenbal January 9, 2025 15:28

SonnyBA marked this pull request as ready for review January 9, 2025 15:28

[#513] moved django-setup-configuration upgrade to breaking changes

5217014

SonnyBA commented Jan 10, 2025

View reviewed changes

src/objects/conf/api.py Outdated Show resolved Hide resolved

Coperh approved these changes Jan 10, 2025

View reviewed changes

[#513] update warning message

871319c

This was referenced Jan 10, 2025

[#513] Release 3.0.0 maykinmedia/objecttypes-api#149

Open

Objects / Objecttypes API release #513

Open

stevenbal requested changes Jan 10, 2025

View reviewed changes

SonnyBA added 3 commits January 13, 2025 16:33

[#513] update version number & release date

c0418bc

[#513] use previous API specification version

6648037

[#513] revert changes to link for API version

5aaf7af

SonnyBA requested a review from stevenbal January 13, 2025 15:49

stevenbal approved these changes Jan 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#513] Release 3.0.0 #517

[#513] Release 3.0.0 #517

SonnyBA commented Jan 9, 2025

SonnyBA Jan 9, 2025

Coperh Jan 10, 2025

stevenbal Jan 10, 2025

SonnyBA Jan 13, 2025

Coperh left a comment

Coperh Jan 10, 2025

Coperh commented Jan 10, 2025

stevenbal Jan 10, 2025

stevenbal left a comment

stevenbal Jan 16, 2025

stevenbal Jan 16, 2025

stevenbal Jan 16, 2025

stevenbal Jan 16, 2025

stevenbal Jan 16, 2025

Hugo-ter-Doest commented Jan 16, 2025

	3.0.0 2025-01-14 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,
	3.0.0 2025-01-16 `ReDoc <https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/objects-api/3.0.0/src/objects/api/v2/openapi.yaml>`_,

[#513] Release 3.0.0 #517

Are you sure you want to change the base?

[#513] Release 3.0.0 #517

Conversation

SonnyBA commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Coperh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Coperh commented Jan 10, 2025

Choose a reason for hiding this comment

stevenbal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hugo-ter-Doest commented Jan 16, 2025