Feature/464 permission admin view slow #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
requested changes
Jan 2, 2025
There was a problem hiding this comment.
I was thinking of the following to make it possible to fetch the fields via the frontend (such that the form doesn't have to be saved to fetch them):
- make an endpoint on the admin (that requires admin authentication) that performs the request for a specific object_type_id to retrieve the
data_fields(e.g./admin/objecttypes/<id>). That way we don't have to expose the token to the frontend and we only need to pass theidto the frontend - in react, call this new endpoint for the currently selected objecttype and display the result
@annashamray what do you think about this?
stevenbal
requested changes
Jan 23, 2025
danielmursa-dev
requested review from
stevenbal
and removed request for
alextreme
annashamray
requested changes
Jan 28, 2025
There was a problem hiding this comment.
One thing I've noticed now, but it's been implemented like this since the beginning:
The state of selected fields is not tracked:
If you change the objecttype in the dropdown and then change it back, the fields previous will not be selected, even if they are saved in the DB
Screencast from 28-01-25 16:32:04.webm
It's been like this probably forever, so could you please create an issue to fix it?
No need to fix it in this PR, but some cleanup would be nice
annashamray
approved these changes
Jan 30, 2025
stevenbal
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
An internal administration endpoint
admin/core/objecttype/<objecttype_id>/_versions/was created to retrieve all versions related to the objecttype.Then the FE part was modified, so that each time an objecttype is modifie/selected, it call a new request to the endpoint.