Add support for django-hijack #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 13 +3
Lines 195 226 +31
Branches 22 27 +5
=========================================
+ Hits 195 226 +31 ☔ View full report in Codecov by Sentry. |
Thanks to @Bartvaderkin for the original implementation Added signals so that hijacking admin users works without entering their second factor by (OTP) logging them in with a temporary device. Special care is taken to ensure hijacking is only allowed for users that are verified, even if you forget to specify a custom permission check. This functionality explicitly tests that it cannot be abused to circumvent multi-factor authentication.
This also requires the user to be verified so the hijack stops before the view fully executes, rather than crashing in the signal receiver.
sergei-maertens
force-pushed
the
feature/hijack-integration
branch
from
cc591ad to
5737be2
Compare
Viicos
reviewed
Feb 5, 2024
|
|
||
|
|
||
| @pytest.fixture | ||
| def mfa_admin_user(admin_user): |
There was a problem hiding this comment.
Is admin_user a pytest-django specific fixture?
Viicos
approved these changes
Feb 5, 2024
Really specific to our particular combination of django-2fa and django-hijack. Of course, users of django-two-factor-auth can always use this library as a source of inspiration :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9