Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#172] Update HPA #173

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[#172] Update HPA #173

wants to merge 4 commits into from

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Jan 28, 2025

Fixes #172

Todo - tests

  • Deploy OZ with autoscaling enabled for nginx/worker
  • Deploy Objecten with autoscaling enabled for the workers

@SilviaAmAm SilviaAmAm marked this pull request as draft January 28, 2025 16:27
@SilviaAmAm SilviaAmAm force-pushed the fix/172-hpa-worker-nginx branch from f7926e7 to 40d08ef Compare January 28, 2025 16:31
@SilviaAmAm SilviaAmAm marked this pull request as ready for review January 29, 2025 13:30
@alextreme
Copy link
Member

Discussed:

  • Silvia will make use of HPA via maykin-utils-lib for OpenArchiefBeheer via a separate PR
  • For now we will only use maykin-utils-lib with OAB, this to ensure we don't run into dependancy problems while iterating on the shared library
  • @Tiho0135 please verify the HPA changes made to the OpenZaak and Objecten charts before approving

@alextreme alextreme requested a review from Tiho0135 January 29, 2025 13:59
@Tiho0135
Copy link

Yes, correct I did not verified the changes, will do that another day, apologies.

@SilviaAmAm
Copy link
Collaborator Author

Silvia will make use of HPA via maykin-utils-lib for OpenArchiefBeheer via a separate PR

#178

@Tiho0135
Copy link

Tiho0135 commented Feb 5, 2025

I created Openzaak deployment with HPA enabled for all possibilities we offer, i.e. webapp, worker, nginx. All seems okay for the first two. For the nginx I do see reference to the nginx mertics and hence I do not know if the HPA in this case would work correctly. We use nginx k8s controller, and nginx ingress, so I do not know if our HPA is referring to nginx the same way it is referring to webapp and worker.
Not completely sure about, but wanted to share my thoughts.
image

@Tiho0135
Copy link

Tiho0135 commented Feb 5, 2025

Using HPA with the following specifications:
targetCPUUtilizationPercentage: 80 targetMemoryUtilizationPercentage: 80
I get the following 7 new replicas pods for the worker deployment. Me personally I cannot explain the reason for this increase, since I do not add extra traffic myself. Maybe all is fine I just wanted to share this finding as well.
Screenshot from 2025-02-05 16-20-51

@Tiho0135
Copy link

Tiho0135 commented Feb 6, 2025

I created Openzaak deployment with HPA enabled for all possibilities we offer, i.e. webapp, worker, nginx. All seems okay for the first two. For the nginx I do see reference to the nginx mertics and hence I do not know if the HPA in this case would work correctly. We use nginx k8s controller, and nginx ingress, so I do not know if our HPA is referring to nginx the same way it is referring to webapp and worker. Not completely sure about, but wanted to share my thoughts. image

Actually, HPA for nginx in OpenZaak seems to be okay after some long time -> for example 2 hours. I would assume all is fine in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HorizontalPodAutoscaling/hpa chart values
3 participants