Skip to content

Commit

Permalink
BUG/MINOR: quic: Possible RX packet memory leak under heavy load
Browse files Browse the repository at this point in the history
This bug could be reproduced with -dMfail and h2load generating plenty of connections.
A "show pools" CLI command showed that some memory in relation with RX packet pool
was never release. Furthermore, adding a RX packet counter to each connection
and a BUG_ON() in quic_conn_release() has proved that this unreleased memory
was in relation with RX packet which were not linked to a connection.

The responsible is quic_dgram_parse() which does not release some RX packet
memory before exiting after the connection thread affinity has changed.

Must be backported as far as 2.7.
  • Loading branch information
haproxyFred authored and a-denoyelle committed Nov 22, 2023
1 parent cd225da commit 7fc5235
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/quic_rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2587,6 +2587,7 @@ int quic_dgram_parse(struct quic_dgram *dgram, struct quic_conn *from_qc,
MT_LIST_APPEND(&quic_dghdlrs[new_tid].dgrams,
&dgram->handler_list);
tasklet_wakeup(quic_dghdlrs[new_tid].task);
pool_free(pool_head_quic_rx_packet, pkt);
goto out;
}

Expand Down

0 comments on commit 7fc5235

Please sign in to comment.