-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor datatype logic #68
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
===========================================
- Coverage 97.95% 87.83% -10.13%
===========================================
Files 5 5
Lines 245 263 +18
===========================================
- Hits 240 231 -9
- Misses 5 32 +27 ☔ View full report in Codecov by Sentry. |
This is a large PR that refactors the way missRanger() deals with variables that cannot be directly modeled by ranger(). The new implementation is slightly more picky, but also more safe.
It is an important step towards out-of-sample application (#58).
Here a summary:
pmm()
is more picky:xtrain
andxtest
must both be either numeric, logical, or factor (with identical levels).ranger()
arguments are now explicit arguments inmissRanger()
to improve tab-completion experience: