Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build out Article index and show views #9

Closed

Conversation

syedbarimanjan
Copy link
Contributor

@syedbarimanjan syedbarimanjan commented Apr 30, 2024

fixes #8
/claim #8

Screencast.from.01-05-2024.19-05-25.mp4

Requirements

  • Match design elements
  • The "gradient" headers should be randomly generated using Tailwind gradients. Ideally would have an array of colors it chooses from so we have some control there.
  • Author avatar should be an if statement based on the author name
  • The "Join waitlist" form should use the existing render_signup_form
  • Read time can likely be a helper method that just measures article length and then converts that to "minutes" to read

I am working on the design and then will refactor it.

@syedbarimanjan syedbarimanjan marked this pull request as ready for review April 30, 2024 22:08
@syedbarimanjan
Copy link
Contributor Author

syedbarimanjan commented Apr 30, 2024

@Shpigford can you take a look.thanks

@syedbarimanjan
Copy link
Contributor Author

syedbarimanjan commented May 1, 2024

@Shpigford reminder to take a look and approve the workflow.thanks

@Shpigford
Copy link
Member

I appreciate your work on this! Ultimately decided to go with #10 due to overall simpler code solutions across the board.

@Shpigford
Copy link
Member

/tip $25

@Shpigford Shpigford closed this May 1, 2024
Copy link

algora-pbc bot commented May 1, 2024

🎉🎈 @syedbarimanjan has been awarded $25! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build out Article index and show views
2 participants