Create reusable newsletter signup component #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@JoshAntBrown Looks good! Mind fixing the linter error? Then I'll merge. |
|
Ah missed that, will pick that up now! |
Looks like a couple more. 🙂 |
|
😅 So there was, looks like I've not got my editor configured properly for this project yet. Should be all sorted now! |
|
Just pushed a small refactor to how the component gets centered, felt like it makes more sense to have the parent dictate things like max width and margins rather than trying to handle it all within the component itself. This should be all good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #1
Resolves #1
This PR adds a SignupsController, a set of views, and a helper to render a signup form anywhere within the website.
It uses a turboframe to constrain the form and it's interaction within the component.
The controller can be updated later to handle the logic of actually adding the email to the email list.