Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stock portfolio backtest calculator #123

Merged
merged 13 commits into from
Sep 2, 2024

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Aug 24, 2024

a.mp4

/closes #122
/claim #122

@neo773 neo773 marked this pull request as ready for review August 24, 2024 18:31
@neo773
Copy link
Contributor Author

neo773 commented Aug 24, 2024

@Shpigford
This is ready to be tested and reviewed

@algora-pbc algora-pbc bot mentioned this pull request Aug 24, 2024
8 tasks
@Shpigford
Copy link
Member

@neo773 Looking good! Here's some feedback for you...

  1. Z-index issue with search dropdown and form labels.
    CleanShot 2024-08-30 at 09 20 07@2x

  2. Clicking this should evenly distribute % across all the stocks. In this case, it'd set both to 50 %.
    CleanShot 2024-08-30 at 09 22 05@2x

  3. We shouldn't use alerts for errors. We should show the error inline in the form.
    CleanShot 2024-08-30 at 09 23 09@2x

  4. Search boxes should prioritize stock symbol matching first over the stock name.
    CleanShot 2024-08-30 at 09 24 59@2x

  5. Graph bottom legend not needed since it's at the top.
    CleanShot 2024-08-30 at 09 26 42@2x

@Shpigford
Copy link
Member

Getting there! A few more bits of feedback...

  1. This always needs to be 100% (meaning the form shouldn't submit and we should show an error message when it doesn't equally 100%).
    CleanShot 2024-09-02 at 05 26 34@2x

  2. It's still using alert messages instead of inline.
    CleanShot 2024-09-02 at 05 28 06@2x

@Shpigford Shpigford merged commit 5e12556 into maybe-finance:main Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Stock Portfolio Backtest
2 participants