feat!: treat empty string as a nil value in deser #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinesaliba
approved these changes
Dec 11, 2024
| @@ -38,6 +38,8 @@ def deserialize_from_creation_params(creation_params) | |||
|
|
|||
| if value.nil? && !field.default.nil? | |||
| Success.new(Validations::ValidatedValue.new(name: field.name, value: field.default)) | |||
| elsif !field.required && (value.nil? || value == "") | |||
There was a problem hiding this comment.
(nitpick) the if before and the elsif after it have the value check first and then the field check so it's a bit faster to read as if we follow that ordering here elsif (value.nil? || value == "") && !field.required
|
Closing this, as it's an opinionated change that probably needs to be handled outside of sorbet-schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a significant pain point when deserializing optional values over JSON (and in hashes) when
nullis not used, and instead, an empty string is present for the absence of a value. This slightly modifies deserialization to treat empty strings asnil, as anecdotally this has been expected behavior.