Merge pull request #438 from maxrchung/Fix-publish-release-for-.NET-5

Fix publish release for .net 5
maxrchung · Apr 14, 2021 · a8c32d3 · a8c32d3
2 parents ba62390 + fda128a
commit a8c32d3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml
@@ -17,8 +17,8 @@ jobs:
       run: |
         cd S2VX.Desktop
         dotnet publish -p:PublishProfile=win-x64
-        zip -j S2VX.zip bin/Release/netcoreapp3.1/publish/S2VX.exe
-        zip -r S2VX.zip Stories
+        cd bin/publish
+        zip --recurse-paths S2VX.zip .
 
     - name: Publish release to GitHub
       id: release-drafter
@@ -32,7 +32,7 @@ jobs:
       uses: actions/upload-release-asset@v1
       with:
         upload_url: ${{ steps.release-drafter.outputs.upload_url }}
-        asset_path: ./S2VX.Desktop/S2VX.zip
+        asset_path: ./S2VX.Desktop/bin/publish/S2VX.zip
         asset_name: S2VX.zip
         asset_content_type: application/zip
       env:

diff --git a/S2VX.Desktop/Properties/PublishProfiles/win-x64.pubxml b/S2VX.Desktop/Properties/PublishProfiles/win-x64.pubxml
@@ -6,12 +6,12 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
   <PropertyGroup>
     <Configuration>Release</Configuration>
     <Platform>Any CPU</Platform>
-    <PublishDir>bin\Release\netcoreapp3.1\publish\</PublishDir>
+    <PublishDir>bin\publish\</PublishDir>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net5.0</TargetFramework>
     <SelfContained>true</SelfContained>
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
-    <PublishSingleFile>True</PublishSingleFile>
+    <PublishSingleFile>False</PublishSingleFile>
     <PublishReadyToRun>False</PublishReadyToRun>
     <PublishTrimmed>True</PublishTrimmed>
   </PropertyGroup>