Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use winsock2.h for MSVC build #112

Merged
merged 1 commit into from
Nov 8, 2023
Merged

use winsock2.h for MSVC build #112

merged 1 commit into from
Nov 8, 2023

Conversation

nono303
Copy link
Contributor

@nono303 nono303 commented Nov 8, 2023

No description provided.

oschwald
oschwald approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! With this change, do you have the extension working on Windows?

@oschwald oschwald merged commit fbc86e3 into maxmind:main Nov 8, 2023
3 checks passed
@nono303
Copy link
Contributor Author

nono303 commented Nov 8, 2023

Thanks! With this change, do you have the extension working on Windows?

Thx @oschwald for your reactivity!
Yes I had it working on Windows - since 3 years https://github.com/nono303/win-build-scripts/blob/master/modules/mod_maxminddb.patch ;)
If you're interested, I can provide build for theses combinations: vc15 vs16 vs17 / x86 x64 / AVX SSE2

nono303 pushed a commit to nono303/win-build-scripts that referenced this pull request Nov 15, 2023
https://github.com/maxmind/mod_maxminddb/pull/112
cf81f48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwald oschwald oschwald approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nono303 @oschwald